Refactor Schemas: Initial Release BugFix, incorrect name causing issues with Manifest generation -- FDS-1442 #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix bug where attribute name is recorded twice
…rly and fix bug where attribute name is recorded twice" This reverts commit 78ba12c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in JSONLD parsing, where instead of referencing
subClassOfin the relationships dictionary, I accidentally referencedparentOfwhich caused some attributes/parents to be recorded twice, with different capitalization, which meant the code to filter out duplicates did not work properly. In the end this caused node data to be overwritten when loading the data into a data model graph, the end output for the user was that required columns showed up as not required in the generated manifest.This fix corrects that issue.
Follow initial notes from user here to test fix.
Ticket here