Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert config to defaults #1539

Merged

Conversation

andrewelamb
Copy link
Contributor

No description provided.

Comment on lines 1 to 2
Sample ID,Patient ID,Tissue Status,Component,Id,entityId
1,1,Healthy,Biospecimen,61a70a22-f26d-46b1-8f6f-29ed54658a58,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional?

Comment on lines 1 to 2
Manifest Submission - Manual test - file-based manifest submission/test-dataset/sample A.txt,1,FASTQ,BulkRNA-seqAssay,,,syn63561932,1453e4c5-9847-4527-b70b-c8b8f5cd89a7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional?

@thomasyu888
Copy link
Member

thomasyu888 commented Nov 12, 2024

Thoughts on either

  1. double merge and not wait for tests to run on Bryan's PR.
  2. Change base to develop on this PR

The intent is to not wait for 12 hours. Ha

@andrewelamb / @BryanFauble

@BryanFauble BryanFauble merged commit 625a9a8 into try-changing-to-function-storage-scope Nov 12, 2024
5 checks passed
@BryanFauble BryanFauble deleted the revert_config_to_defaults branch November 12, 2024 16:42
@BryanFauble
Copy link
Collaborator

Thoughts on either

1. double merge and not wait for tests to run on Bryan's PR.

2. Change base to develop on this PR

The intent is to not wait for 12 hours. Ha

@andrewelamb / @BryanFauble

Will be looking at the test run in #1537 which will contain everything for both sets of changes

Copy link

sonarcloud bot commented Nov 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants