Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMATIC-212] Prevent traces from being combined #1552

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

BryanFauble
Copy link
Collaborator

@BryanFauble BryanFauble commented Nov 22, 2024

Problem:

  1. When integration tests were run the telemetry data in SigNoz was combining a bunch of traces under the same trace as shown in the screenshot:

Untitled

Solution:

  1. Un-Instrument the flask auto tracing that causes issues when running a local flask test server.
  2. Adding in logic to add the github branch to the created traces/logs in order to filter out specific test/branch runs

Testing:

  1. The run from this github action looks good!

Comment on lines +46 to +47
FlaskInstrumentor().uninstrument()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make us lose much. Mostly just the hooks for tracking what arguments were sent into the flask server, but isn't that important since we can just look at the integration test.

@BryanFauble BryanFauble marked this pull request as ready for review November 22, 2024 19:36
@BryanFauble BryanFauble requested a review from a team as a code owner November 22, 2024 19:36
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! I'll have someone else do a final review for cross training efforts.

Copy link
Collaborator

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryanFauble BryanFauble merged commit c3e0732 into develop Nov 25, 2024
4 checks passed
@BryanFauble BryanFauble deleted the schematic-212-telemetry-combining branch November 25, 2024 20:07
Copy link

sonarcloud bot commented Nov 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants