Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMATIC-214] Wrap pandas functions to support not including None with the NA values argument #1553

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

BryanFauble
Copy link
Collaborator

Problem:

  1. When the None string is included with a manifest the pandas function was causing it to be converted over to a float not a number (NaN). This is a change in Pandas 2.0 release: "Added "None" to default na_values in read_csv() (GH 50286)"

Solution:

  1. Grab the existing list of na_value objects and remove the None value from the list. Pass that list back into the function and replace the default na_value objects with this new list.

Testing:

  1. Unit testing
  2. Further testing is needed

@thomasyu888 thomasyu888 changed the title [SCHEMATIC-210] Wrap pandas functions to support not including None with the NA values argument [SCHEMATIC-214] Wrap pandas functions to support not including None with the NA values argument Nov 22, 2024
Copy link

sonarcloud bot commented Nov 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant