Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix QUIC stream close #21

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

fix QUIC stream close #21

wants to merge 4 commits into from

Conversation

dyhkwong
Copy link

Current implementation does not work with some public DoQ servers (e.g. quic://dns.nextdns.io)

https://datatracker.ietf.org/doc/html/rfc9250#section-4.2-6

  • The client MUST send the DNS query over the selected stream and MUST indicate through the STREAM FIN mechanism that no further data will be sent on that stream.
  • Servers MAY defer processing of a query until the STREAM FIN has been indicated on the stream selected by the client.

And btw line 156-157 defer stream.Close() and defer stream.CancelRead(0) seems unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyhkwong @nekohasekai