Skip to content

internationalized added #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

erhany
Copy link

@erhany erhany commented Feb 25, 2025

No description provided.

@Saifullah-dev
Copy link
Owner

@erhany Sorry for the late response.

I've reviewed the Pull Request, there are some errors with the exported variables and callbacks from useFileList.jsx hook.
You may fix them for successful merge into main.

Thank you for the contribution.

@erhany
Copy link
Author

erhany commented Mar 4, 2025

@erhany Sorry for the late response.

I've reviewed the Pull Request, there are some errors with the exported variables and callbacks from useFileList.jsx hook. You may fix them for successful merge into main.

Thank you for the contribution.

I didn't understand where the error was.

@Saifullah-dev
Copy link
Owner

@erhany The exported variables from the useFileList.jsx are not accessible due to injectIntl export.

@Cokser
Copy link

Cokser commented Mar 5, 2025

@Saifullah-dev, @erhany
I'm not sure if this feature is a good idea, because text, captions and labels is usually something that has to be handled outside of library.
So it's better to add a label-config that will be passed from outside by the user.
Something like this:

<FileManager
     config={{
       labels: {
         "toolbar.cut": "Cut", //   here user should put his i18n values
         "toolbar.rename": "Rename",
         ...,
         "contextMenu.open": "Open",
         "modal.chooseFile": "Choose File",
       },
     }}
/>

Also in the PR I've created for the actions, there's a title where you can put localized captions.
So it can help shorten labels config

@erhany
Copy link
Author

erhany commented Mar 7, 2025

I understand what you mean @Cokser but I don't have the full knowledge of how to do it. Can you add labels as you suggested? @Saifullah-dev @Cokser

@erhany
Copy link
Author

erhany commented Mar 11, 2025

Will you take any action regarding this issue?
@Saifullah-dev @Cokser

@Cokser
Copy link

Cokser commented Mar 11, 2025

@erhany I'm waiting for review of #175, so I would be able to proceed with this issue.

@Saifullah-dev
Copy link
Owner

@Cokser @erhany Will resolve both today.

@PailletJuanPablo
Copy link

Any updates on this ? The feature would be useful

@erhany
Copy link
Author

erhany commented Mar 13, 2025

@Saifullah-dev

@erhany erhany closed this Mar 13, 2025
@erhany erhany reopened this Mar 13, 2025
@erhany
Copy link
Author

erhany commented Apr 3, 2025

Hello @Cokser, if you have done internationalization work, can you share it with me? @Saifullah-dev seems like he won't find a solution.

@Cokser
Copy link

Cokser commented Apr 17, 2025

Hello @Cokser, if you have done internationalization work, can you share it with me? @Saifullah-dev seems like he won't find a solution.

Sorry @erhany, I moved on to different solution✌️

@Saifullah-dev
Copy link
Owner

Saifullah-dev commented Apr 19, 2025

@erhany @Cokser @PailletJuanPablo This feature has been added in the v1.21.0 version of react-file-manager 🚀

Again, sorry for the late release as I was quite busy with work stuff. Thanks.

@erhany
Copy link
Author

erhany commented Apr 22, 2025

@Saifullah-dev No problem at all, I totally understand. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants