Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Intake and Shooter #27

Merged
merged 6 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/frc/robot/Constants.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public static final class IOConstants {
public static final int kDriverControllerPort = 0;
public static final int kOperatorControllerPort = 1;

public static final double kControllerDeadband = 0.05;
public static final double kControllerDeadband = 0.1;
public static final double kSlowModeScalar = 0.8;
}

Expand Down Expand Up @@ -117,7 +117,8 @@ public static final class IntakeConstants {
public static final class ShooterConstants {
public static final int kTopShooterMotorPort = 20;
public static final int kBottomShooterMotorPort = 35;
public static final double kShooterSpeed = 0.7;
public static final double kShooterSpeedTop = 0.75;
public static final double kShooterSpeedBottom = 0.9;
public static final double kShooterOff = 0;
}

Expand Down
24 changes: 12 additions & 12 deletions src/main/java/frc/robot/subsystems/DriveSubsystem.java
Original file line number Diff line number Diff line change
Expand Up @@ -94,18 +94,18 @@ public void periodic() {

m_field.setRobotPose(m_poseEstimator.getEstimatedPosition());

SmartDashboard.putNumber("gyro angle", m_gyro.getAngle());
SmartDashboard.putNumber("odometryX", m_poseEstimator.getEstimatedPosition().getX());
SmartDashboard.putNumber("odometryY", m_poseEstimator.getEstimatedPosition().getY());

// AdvantageScope Logging
double[] logData = {
m_frontLeft.getPosition().angle.getDegrees(), m_frontLeft.driveOutput,
m_frontRight.getPosition().angle.getDegrees(), m_frontRight.driveOutput,
m_rearLeft.getPosition().angle.getDegrees(), m_rearLeft.driveOutput,
m_rearRight.getPosition().angle.getDegrees(), m_rearRight.driveOutput,
};
SmartDashboard.putNumberArray("AdvantageScope Swerve States", logData);
// SmartDashboard.putNumber("gyro angle", m_gyro.getAngle());
// SmartDashboard.putNumber("odometryX", m_poseEstimator.getEstimatedPosition().getX());
// SmartDashboard.putNumber("odometryY", m_poseEstimator.getEstimatedPosition().getY());

// // AdvantageScope Logging
// double[] logData = {
// m_frontLeft.getPosition().angle.getDegrees(), m_frontLeft.driveOutput,
// m_frontRight.getPosition().angle.getDegrees(), m_frontRight.driveOutput,
// m_rearLeft.getPosition().angle.getDegrees(), m_rearLeft.driveOutput,
// m_rearRight.getPosition().angle.getDegrees(), m_rearRight.driveOutput,
// };
// SmartDashboard.putNumberArray("AdvantageScope Swerve States", logData);

setModuleStates(swerveModuleStates);
}
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/frc/robot/subsystems/IntakeSubsystem.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class IntakeSubsystem extends SubsystemBase {

private DutyCycleEncoder m_armEncoder = new DutyCycleEncoder(IntakeConstants.kArmEncoderChannel);

private Rev2mDistanceSensor m_distanceSensor = new Rev2mDistanceSensor(Port.kOnboard); // onboard I2C port;
private Rev2mDistanceSensor m_distanceSensor = new Rev2mDistanceSensor(Port.kMXP); // onboard I2C port;

private double m_intakeSpeed = 0;
private double m_armSetpoint = IntakeConstants.kIntakeRaisedAngle;
Expand All @@ -40,8 +40,8 @@ public IntakeSubsystem() {
SmartDashboard.putNumber("arm", m_armEncoder.getAbsolutePosition());
m_armEncoder.setDistancePerRotation(360);

m_intakeMotor.setIdleMode(IdleMode.kBrake);
m_armMotor.setIdleMode(IdleMode.kCoast);
m_intakeMotor.setIdleMode(IdleMode.kCoast);
m_armMotor.setIdleMode(IdleMode.kBrake);

m_armPID.setTolerance(10);

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/frc/robot/subsystems/ShooterSubsystem.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ public void reset() {
public void setShootingSpeed(ShootSpeed speed) {
switch (speed) {
case Shooting:
m_topSpeed = ShooterConstants.kShooterSpeed;
m_bottomSpeed = ShooterConstants.kShooterSpeed;
m_topSpeed = ShooterConstants.kShooterSpeedTop;
m_bottomSpeed = ShooterConstants.kShooterSpeedBottom;
// System.out.println("shoot speed: " + ShooterConstants.kShooterSpeed);
break;
case Off:
Expand Down
Loading