Fix: Unlock PIN method returning 101006 Unknown Error #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salamek
requested changes
Aug 21, 2024
huawei_lte_api/api/Pin.py
Outdated
| @@ -14,8 +14,8 @@ def simlock(self) -> GetResponseType: | |||
| def save_pin(self) -> GetResponseType: | |||
| return self._session.get('pin/save-pin') | |||
|
|
|||
| def operate(self, operate_type: int = 0, current_pin: Optional[int] = None, | |||
| new_pin: Optional[int] = None, puk_code: Optional[int] = None) \ | |||
| def operate(self, operate_type: str = 0, current_pin: Optional[str] = None, | |||
There was a problem hiding this comment.
Default arg. for operate_type should be '0' (string) not 0 (int).
There was a problem hiding this comment.
Dont know how I missed that :(
Fix: Unlock PIN method returning 101006 Unknown Error
Salamek
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong:
The unlock_pin method was returning the error code 101006 Unknown Error and failing to unlock the PIN on certain modem models, including the E3372.
What you did to fix it:
The cause of this issue was identified as incorrectly typing the data provided to the /pin/operate endpoint. Additionally, The request was not encrypting the data sent.
Any additional testing or considerations:
I tested the fix on one modem model, The E3372.
This fix should resolve the issues detailed in Issue #223. Please review the changes and let me know if further adjustments are needed.