Merge pull request #146 from SalesforceFoundation/feature/234

SFDO 234 Winter '21 Major Release ☃️ ☕ 🎿

.lintstagedrc

@@ -3,12 +3,12 @@
         "prettier --write"
     ],
     "*.{cls,apex,js,html,md,xml,sql,py,yml,yaml,cmp,design}": [
-        "cspell"
+        "cspell --no-must-find-files"
     ],
     "*.js": [
         "eslint"
     ],
     "yarn.lock": [
         "lockfile-lint"
     ]
-}
+}

README.md

@@ -1,6 +1,8 @@
 # Outbound Funds
 
-![Outbound Funds Logo](https://github.com/SalesforceFoundation/OutboundFundsModule/blob/master/images/Outbound%20Funds%20OSC%20Logo%20250x250.png)
+<p align="center">
+  <img src="https://github.com/SalesforceFoundation/OutboundFundsModule/blob/master/images/Outbound%20Funds%20OSC%20Logo%20250x250.png" alt="Outbound Funds Module Logo"/>
+</p>
 
 The Outbound Funds app is a community developed and maintained Open Source Commons project. It is a customizable foundation for managing funds awarded by your organization, like grants, scholarships or internal funding.
 
@@ -12,7 +14,7 @@ Links:
 
 ## Latest Release
 
-Summer '21 🌞 ⛵ 🌊
+Winter '22 ☃️ ☕ 🎿
 
 **Important note about Funding Requests as of July 2019**:
 If you were an early adopter of the Outbound Funds package, the Funding Request object had a master-detail relationship with Funding Program when you installed it. However, various members of the community requested that this relationship be changed to a lookup to provide more flexibility. This change was made generally available with package version 1.15 as of 7/11/2019. To learn about updating to version 1.15, see the [Funding Request Object documentation](https://github.com/SalesforceFoundation/OutboundFundsModule/wiki/Funding-Request-Object).

force-app/main/default/objectTranslations/Funding_Request__c-fr/Applying_Organization__c.fieldTranslation-meta.xml

@@ -2,5 +2,5 @@
 <CustomFieldTranslation xmlns="http://soap.sforce.com/2006/04/metadata">
     <name>Applying_Organization__c</name>
     <relationshipLabel>Demandes de subvention</relationshipLabel>
-    <label>Organisation demandeur</label>
+    <label>Organisation demandeuse</label>
 </CustomFieldTranslation>

force-app/main/default/objectTranslations/Review__c-de/Review__c-de.objectTranslation-meta.xml

@@ -3,58 +3,58 @@
     <layouts>
         <layout>Review Layout</layout>
         <sections>
-            <label>†berprŸfung</label>
+            <label>Überprüfung</label>
             <section>Review</section>
         </sections>
         <sections>
             <label>Benutzerdefinierte Links</label>
             <section>Custom Links</section>
         </sections>
     </layouts>
-    <nameFieldLabel>Name der †berprŸfung</nameFieldLabel>
+    <nameFieldLabel>Name der Überprüfung</nameFieldLabel>
     <standardFields>
         <name>Name</name>
-        <label>Name der †berprŸfung</label>
+        <label>Name der Überprüfung</label>
     </standardFields>
     <gender>Feminine</gender>
     <caseValues>
         <plural>false</plural>
         <caseType>Nominative</caseType>
-        <value>†berprŸfung</value>
+        <value>Überprüfung</value>
     </caseValues>
     <caseValues>
         <plural>false</plural>
         <caseType>Accusative</caseType>
-        <value>†berprŸfung</value>
+        <value>Überprüfung</value>
     </caseValues>
     <caseValues>
         <plural>false</plural>
         <caseType>Dative</caseType>
-        <value>†berprŸfung</value>
+        <value>Überprüfung</value>
     </caseValues>
     <caseValues>
         <plural>false</plural>
         <caseType>Genitive</caseType>
-        <value>†berprŸfung</value>
+        <value>Überprüfung</value>
     </caseValues>
     <caseValues>
         <plural>true</plural>
         <caseType>Nominative</caseType>
-        <value>†berprŸfungen</value>
+        <value>Überprüfungen</value>
     </caseValues>
     <caseValues>
         <plural>true</plural>
         <caseType>Accusative</caseType>
-        <value>†berprŸfungen</value>
+        <value>Überprüfungen</value>
     </caseValues>
     <caseValues>
         <plural>true</plural>
         <caseType>Dative</caseType>
-        <value>†berprŸfungen</value>
+        <value>Überprüfungen</value>
     </caseValues>
     <caseValues>
         <plural>true</plural>
         <caseType>Genitive</caseType>
-        <value>†berprŸfungen</value>
+        <value>Überprüfungen</value>
     </caseValues>
-</CustomObjectTranslation>
+</CustomObjectTranslation>

force-app/main/default/objects/Review__c/listViews/OpenReviews.listView-meta.xml

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ListView xmlns="http://soap.sforce.com/2006/04/metadata">
     <fullName>OpenReviews</fullName>
-    <columns>FundingRequest__c</columns>
     <columns>NAME</columns>
+    <columns>FundingRequest__c</columns>
     <columns>Status__c</columns>
     <columns>DueDate__c</columns>
     <columns>Comments__c</columns>

robot/OutboundFunds/resources/OutboundFunds.py

@@ -206,18 +206,28 @@ def click_related_list_wrapper_button(self, heading, button_title):
 
     @capture_screenshot_on_error
     def click_related_list_link(self, text):
+        """Click on link with passed text"""
+        locator = outboundfunds_lex_locators["related"]["link"].format(text)
+        self.selenium.wait_until_page_contains_element(locator)
+        element = self.selenium.driver.find_element_by_xpath(locator)
+        self.selenium.driver.execute_script("arguments[0].click()", element)
+
+    def click_flexipage_related_list_link(self, text):
         """Click on link with passed text"""
         locator = outboundfunds_lex_locators["related"]["flexi_link"].format(text)
         self.selenium.wait_until_page_contains_element(locator)
         element = self.selenium.driver.find_element_by_xpath(locator)
         self.selenium.driver.execute_script("arguments[0].click()", element)
 
+
     @capture_screenshot_on_error
     def select_value_from_picklist(self, dropdown, value):
         """Select given value in the dropdown field"""
         locator = outboundfunds_lex_locators["new_record"]["dropdown_field"].format(
             dropdown
         )
+        self.selenium.wait_until_page_contains_element(locator)
+        self.selenium.get_webelement(locator).click()
         self.selenium.get_webelement(locator).click()
         popup_loc = outboundfunds_lex_locators["new_record"]["dropdown_popup"]
         self.selenium.wait_until_page_contains_element(

robot/OutboundFunds/resources/RequirementPageObject.py

@@ -14,7 +14,7 @@ def _is_current_page(self):
         """
         self.selenium.location_should_contain(
             "Requirement__c/list?",
-            message="Current page is not a Funding Program List view",
+            message="Current page is not a Requirement List view",
         )
 
 

robot/OutboundFunds/resources/locators_52.py

@@ -50,7 +50,8 @@
         "button": "//div[contains(@class, 'forceRelatedListSingleContainer')][.//img][.//span[@title='{}']]//a[@title='{}']",
         "count": "//tbody/tr/td[1]",
         "flexi_button": "//div[@lst-listviewmanagerheader_listviewmanagerheader][.//span[@title='{}']]//lightning-button//button[text()='{}']",
-        "flexi_link": "//a//span[text()='{}']",
+        "flexi_link": "//a//span[contains(text(),'{}')]",
+        "link": "//a[contains(text(),'{}')]",
     },
     "details": {
         "button": "//button[contains(@class, 'slds-button') and text() = '{}']",

robot/OutboundFunds/tests/browser/Disbursements/DisbursementPermissions.robot

@@ -47,4 +47,4 @@ Disbursement FLS Check
     click button                                Calculate
     Wait Until Element Is Visible               text:Scheduled Date
     Save Disbursement
-    Wait Until Element Is Visible               text:Error
+    Wait Until Element Is Visible               text:Resolve error

robot/OutboundFunds/tests/browser/Requirements/Requirements.robot

@@ -59,7 +59,9 @@ Add a Requirement on a Funding Request
     ...                                         Assigned=PermsTestingUser RobotUser
     Click Save
     Verify Toast Message                        Requirement
+    Go to page                                  Listing          ${ns}Requirement__c
     Click Related List Link                     ${req_name}
+    Click Tab                                   Details
     Validate Field Value                        Requirement Name   contains   ${req_name}
     Validate Field Value                        Primary Contact    contains    ${contact}[Name]
 

robot/OutboundFunds/tests/browser/Review/Review.robot

@@ -66,8 +66,8 @@ Add a Review on a Funding Request
     Page Should Contain Element                 //span[@title='Review Name']
     Page Should Contain Element                 //span[@title='Status']
     Page Should Contain Element                 //span[@title='Assigned To']
-    Page Should Contain Element                 //span[@title='Due Date']
-    Click Related List Link                     ${review_name1}
+    Page Should Contain Element                 //span[@title='Due Date']    
+    Click Flexipage Related List Link           ${review_name1}
     Validate Field Value                        Review Name   contains   ${review_name1}
 
 Create a Review via Review Object Tab

robot/OutboundFunds/tests/browser/Review/SubmitReview.robot

@@ -45,13 +45,7 @@ Submit a Review
     ${today} =                                  Get current date        result_format=%-m/%d/%Y
     Go To Page                                  Details     Review__c
     ...                                         object_id=${review}[Id]
-    Current Page Should Be                      Details             Review__c
-    Click Button                                Edit
-    Wait until modal is open
-    Select Value from Picklist                  Status          In Progress
-    Click Save
-    Verify Toast Message                        Review
-    Current Page Should Be                      Details             Review__c
+    Current Page Should Be                      Details             Review__c    
     Validate Field Value                        Status    contains    In Progress
     Click Button                                Submit Review
     Wait until modal is open