Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use private GitHub Actions runners #205

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Use private GitHub Actions runners #205

merged 1 commit into from
Jan 17, 2024

Conversation

sella24
Copy link
Contributor

@sella24 sella24 commented Jan 17, 2024

Due to IP restriction, only jobs running in Enterprise runners can
access Salesforce repositories.

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@sella24 sella24 requested a review from a team as a code owner January 17, 2024 18:35
@sella24 sella24 requested review from sreddy-sf and jstvz January 17, 2024 18:35
jstvz
jstvz approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS 🆗

@jstvz jstvz merged commit 6692d91 into master Jan 17, 2024
15 of 18 checks passed
@jstvz jstvz deleted the feature/github-actions-private-runners branch January 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstvz jstvz jstvz approved these changes

@sreddy-sf sreddy-sf Awaiting requested review from sreddy-sf sreddy-sf is a code owner automatically assigned from SalesforceFoundation/release-engineering-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sella24 @jstvz