Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP addresses rules and filters #394

Merged
merged 4 commits into from
Aug 28, 2023
Merged

IP addresses rules and filters #394

merged 4 commits into from
Aug 28, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 3, 2023

Description

Please include a summary of the change and which is fixed.

  • Add IPv4 and IPv6 rules and filter for the ip addresses (internal network are skipped too)

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek force-pushed the ip branch 2 times, most recently from 3a4dce2 to 0ee1b73 Compare August 7, 2023 12:50
@babenek babenek closed this Aug 9, 2023
@babenek babenek reopened this Aug 9, 2023
@babenek babenek force-pushed the ip branch 3 times, most recently from 573db82 to c8cd644 Compare August 14, 2023 10:24
@babenek babenek force-pushed the ip branch 2 times, most recently from 5d7e4ae to 2821433 Compare August 17, 2023 10:03
@babenek babenek changed the title Ip IP addresses rules and filters Aug 17, 2023
@babenek babenek marked this pull request as ready for review August 23, 2023 17:57
@babenek babenek requested a review from a team as a code owner August 23, 2023 17:57
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding IP address detection rules.

LGTM 👍

Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@babenek babenek merged commit 5e4ae50 into Samsung:main Aug 28, 2023
@babenek babenek deleted the ip branch August 28, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants