Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword rules for --doc only #420

Merged
merged 23 commits into from
Oct 20, 2023
Merged

keyword rules for --doc only #420

merged 23 commits into from
Oct 20, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Sep 11, 2023

Description

Please include a summary of the change and which is fixed.

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark - should be not touched due --doc is not used in benchmark
  • TODO: remove temporally version changing - one test failed

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f31f2bb) 90.77% compared to head (c106cf6) 90.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   90.77%   90.78%   +0.01%     
==========================================
  Files         125      125              
  Lines        4172     4179       +7     
  Branches      661      662       +1     
==========================================
+ Hits         3787     3794       +7     
  Misses        252      252              
  Partials      133      133              
Files Coverage Δ
credsweeper/rules/rule.py 89.13% <100.00%> (+0.40%) ⬆️
credsweeper/scanner/scanner.py 93.69% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek changed the title Dockeyword keyword rules for --doc only Oct 6, 2023
@babenek babenek marked this pull request as ready for review October 6, 2023 11:01
@babenek babenek requested a review from a team as a code owner October 6, 2023 11:01
@babenek babenek marked this pull request as draft October 10, 2023 07:57
@babenek babenek marked this pull request as ready for review October 16, 2023 09:44
credsweeper/__init__.py Outdated Show resolved Hide resolved
tests/test_app.py Outdated Show resolved Hide resolved
@babenek
Copy link
Contributor Author

babenek commented Oct 19, 2023

TODO: remove temporally versionisation with datetime (?)

Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests updated

tests/test_app.py Outdated Show resolved Hide resolved
tests/test_app.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unstructured pattern rules are covered by this PR.
We should improve more about this but it's okay for now.

LGTM 👍

@babenek babenek mentioned this pull request Oct 20, 2023
2 tasks
@babenek babenek merged commit 19bbb24 into Samsung:main Oct 20, 2023
29 checks passed
@babenek babenek deleted the dockeyword branch October 21, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants