-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyword rules for --doc only #420
Conversation
Co-authored-by: ShinHyung Choi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 90.77% 90.78% +0.01%
==========================================
Files 125 125
Lines 4172 4179 +7
Branches 661 662 +1
==========================================
+ Hits 3787 3794 +7
Misses 252 252
Partials 133 133
☔ View full report in Codecov by Sentry. |
- PIN keyword removed - The verb strings of delimiter are removed
TODO: remove temporally versionisation with datetime (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unstructured pattern rules are covered by this PR.
We should improve more about this but it's okay for now.
LGTM 👍
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.
--doc
is not used in benchmark