-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit hook description added to documentation. #442
Conversation
pre-commit file body and description added.
pre-commit description added to install.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding sample of pre-commit script which compatible with linux and windows!
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 125 125
Lines 4168 4168
Branches 659 659
=======================================
Hits 3786 3786
Misses 251 251
Partials 131 131 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
Co-authored-by: ShinHyung Choi <[email protected]>
Co-authored-by: ShinHyung Choi <[email protected]>
Agree. See comments upper. Co-authored-by: Roman Babenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay,
only added credentials will block commit.
However, there is comprehensive information in capital letters.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit hook description added.
LGTM 👍
* pre-commit description added to install.rst pre-commit file body and description added. * Update docs/source/install.rst * Update docs/source/install.rst Co-authored-by: ShinHyung Choi <[email protected]> * Update docs/source/install.rst Co-authored-by: ShinHyung Choi <[email protected]> * Update docs/source/install.rst Agree. See comments upper. Co-authored-by: Roman Babenko <[email protected]> --------- Co-authored-by: Roman Babenko <[email protected]> Co-authored-by: ShinHyung Choi <[email protected]>
Description
How has this been tested?