Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters optimisation #588

Merged
merged 20 commits into from
Aug 9, 2024
Merged

Filters optimisation #588

merged 20 commits into from
Aug 9, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 23, 2024

Description

Please include a summary of the change and which is fixed.

  • Add variable sanitizer case
  • Removed filter for length check as duplicated activity
  • updated LineSpecificKeyCheck to check the specific keys near value - long lines FN issue fix.
  • customized size for url credentials to deal real passwords more than 31 symbols (URL safe encodings case and so on)
  • ML retrain will be done in next PR to fit new cleaned variables

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review August 7, 2024 18:40
@babenek babenek requested a review from a team as a code owner August 7, 2024 18:40
@@ -23,7 +23,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: babenek/CredData
ref: jwt
ref: auxiliary
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback after Samsung/CredData#158

@babenek babenek merged commit e31ef71 into Samsung:main Aug 9, 2024
27 checks passed
@babenek babenek deleted the auxiliary branch August 9, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants