Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tencent WeChat API App ID #617

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Tencent WeChat API App ID #617

merged 4 commits into from
Nov 8, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Nov 6, 2024

Description

Please include a summary of the change and which is fixed.

  • Add pattern Tencent WeChat API App ID

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek requested a review from a team as a code owner November 6, 2024 07:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (8682ea7) to head (e2a48c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         146      146           
  Lines        4972     4972           
  Branches      805      805           
=======================================
  Hits         4528     4528           
  Misses        290      290           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

credsweeper/rules/config.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems new WeCaht API rule is too weak to apply to doc..
Could you remove doc from the target?
Or is it doesn't matter we check confidence level before scanning?

BTW adding new rule is LGTM 👍

@babenek babenek merged commit fcfbf97 into Samsung:main Nov 8, 2024
27 checks passed
@babenek babenek deleted the wechat branch November 8, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants