Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilio Credentials #619

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Twilio Credentials #619

merged 12 commits into from
Nov 11, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Nov 6, 2024

Description

Please include a summary of the change and which is fixed.

  • Rename Twilio API Key to Twilio Credentials and add more patterns for the rule

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

credsweeper/rules/config.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback after Samsung/CredData#173 merge

.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
@babenek babenek changed the title Twilio credentials Twilio Credentials Nov 8, 2024
@babenek babenek marked this pull request as ready for review November 11, 2024 10:09
@babenek babenek requested a review from a team as a code owner November 11, 2024 10:09
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit 5cc9685 into Samsung:main Nov 11, 2024
27 checks passed
@babenek babenek deleted the twilio branch November 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants