Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircleEditor] Clean dead codes #1620

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Aug 24, 2023

This commit removes clang-format related dead codes.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]


From #1617

This commit removes clang-format related dead codes.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 requested a review from a team August 24, 2023 08:37
@dayo09 dayo09 added the 2 approvals 2 approvals required to be merged label Aug 24, 2023
@@ -867,7 +866,7 @@ view.View = class {
url: "https://github.com/lutzroeder/netron/issues/649",
},
];
// clang-format on
// on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this comment?

@dayo09 dayo09 added 1 approval 1 approval required to be merged and removed 2 approvals 2 approvals required to be merged labels Sep 7, 2023
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit 3779924 into Samsung:main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval 1 approval required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants