Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Remove executors #1636

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Sep 12, 2023

This commit removes executors as they are not used anywhere.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]

@dayo09 dayo09 added the 2 approvals 2 approvals required to be merged label Sep 12, 2023
jyoungyun
jyoungyun previously approved these changes Sep 12, 2023
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's consider the device view logic later.

@dayo09 dayo09 requested a review from a team September 12, 2023 09:22
mhs4670go
mhs4670go previously approved these changes Sep 13, 2023
@mhs4670go
Copy link
Contributor

It needs to resolve conflicts.

This commit removes executors as they are not used anywhere.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09
Copy link
Contributor Author

dayo09 commented Sep 13, 2023

@mhs4670go @jyoungyun Rebased :-D

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit 1354870 into Samsung:main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals 2 approvals required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants