-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneExplorer] Targeted refresh on Change/Delete #1710
Conversation
06798a6
to
89c8ec1
Compare
This commit refreshs only the required nodes on change and delete file. ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
89c8ec1
to
6edff6e
Compare
I can't fully understand your code at once. Could you explain the change you made in this PR? :) |
@jyoungyun Sure :-D Do you remember that the explorer flickers and folds all the nodes whenever there are file changes? (1) On Cfg file change:
(2) On Product(circle/tvn/log, ...) delete:
It's all for change/delete. I am working on 'create' event. |
Does this have nothing to do with folding whenever there is a file change? Because when I tested this PR, if I build cfg and create a new product file, it still folds. I thought this change is related to the folding issue. :) |
On creation, I am working on it! :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit refreshs only the required nodes on change and delete file.
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]
For #1422 #1501