Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeTPU] Introduce EdgeTPUCfgEditorPanel #1739

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Nov 2, 2023

This commit creates EdgeTPUCfgEditorPanel.ts that is a panel for .edgetpucfg.

  • Create EdgetpuCfgEditorPanel.ts : Cfg Editor Panel for edgetpu cfg editor
  • Add register in extension.ts
  • Map a new view type with a new file extension - .edgetpucfg
  • Error fix : Duplication of setDefaultValues causes error so changed the command name to "setDefaultEdgetpuValues".
  • Add objects about setDefaultEdgetpuValues in Commands and Keybindings in package.json

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee [email protected]
For #1726

This commit creates EdgeTPUCfgEditorPanel.ts that is a panel for .edgetpucfg.
- Create EdgetpuCfgEditorPanel.ts : Cfg Editor Panel for edgetpu cfg editor
- Add register in extension.ts
- Map a new view type with a new file extension - .edgetpucfg
- Error fix : Duplication of setDefaultValues causes error so changed the command name to "setDefaultEdgetpuValues".
- Add objects about setDefaultEdgetpuValues in Commands and Keybindings in package.json

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
Co-authored-by: Bumsoo Ko <[email protected]>
Co-authored-by: Hyeon-Uk <[email protected]>
@dayo09 dayo09 added 1 approval 1 approval required to be merged SSAFY labels Nov 2, 2023
@dayo09 dayo09 requested a review from a team November 3, 2023 02:17
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit 8e23f02 into Samsung:main Nov 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval 1 approval required to be merged SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants