Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeTPU] Update Toolchain run notification and log #1745

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Nov 3, 2023

Modify notiTitle in JobConfig.ts from 'Running onecc...' to 'Running tools...' Use active toolchain name in notification and log of ToolchainProvider _run method

ONE-vscode-DCO-1.0-Signed-off-by: profornnan [email protected]


Origianl PR #1698
For #1726

Modify notiTitle in JobConfig.ts from 'Running onecc...' to 'Running tools...'
Use active toolchain name in notification and log of ToolchainProvider _run method

ONE-vscode-DCO-1.0-Signed-off-by: profornnan <[email protected]>
@dayo09 dayo09 requested a review from jyoungyun November 3, 2023 05:28
@dayo09
Copy link
Contributor Author

dayo09 commented Nov 3, 2023

1103

Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,7 +27,7 @@ class JobConfig extends JobCommand {
super(cmd);
this.jobType = JobType.tConfig;
this.name = "config";
this.notiTitle = "Running onecc...";
this.notiTitle = "Running tools...";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jyoungyun jyoungyun merged commit ceb9b8b into Samsung:main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants