[workflows] Replace deprecated command with environment file #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replace deprecated command with environment file. ONE-vscode-DCO-1.0-Signed-off-by: Jongwoo Han <[email protected]>
|
Looks good this PR. However, could you fork this repository and make a pr again? |
@jyoungyun I have currently forked this repository and created a PR, may I ask why you suggested creating a PR again? |
I asked to make another PR because PR check was not executed. |
jongwooo
deleted the
replace-deprecated-command-with-environment-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONE-vscode-DCO-1.0-Signed-off-by: Jongwoo Han [email protected]
Summary
Update
.github/workflows/check-daily-license.ymlto use environment file instead of deprecatedset-outputcommand. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/AS-IS
echo "::set-output name=commit_id::${COMMIT_ID}"TO-BE
echo "commit_id=${COMMIT_ID}" >> $GITHUB_OUTPUT