Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/service] Add Assert about Shape Inference Condition for Range #14002

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kyeong8139
Copy link
Contributor

This commit add comment about shape inference condition for Range.

Related: #13987 (comment)

@kyeong8139 kyeong8139 added PR/ready for review It is ready to review. Please review it. SSAFY labels Sep 12, 2024
@kyeong8139 kyeong8139 requested review from a team September 12, 2024 06:19
This commit add assert shape inference condition for Range.

ONE-DCO-1.0-Signed-off-by: bokyeong lee <[email protected]>
@kyeong8139 kyeong8139 changed the title [luci/service] Add Comment about Shape Inference Condition for Range [luci/service] Add Assert about Shape Inference Condition for Range Sep 12, 2024
Copy link
Contributor

@Seunghui98 Seunghui98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@seanshpark seanshpark merged commit 5054c29 into Samsung:master Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it. SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants