-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT][dredd] Introduce dredd test for TensorShape #14050
Changes from 3 commits
7bf462c
2178227
98cd197
9242803
2354adc
a551138
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -96,6 +96,7 @@ Add(PadV2_001 PASS substitute_padv2_to_pad) | |||||||
Add(Softmax_001 PASS decompose_softmax) | ||||||||
Add(Softmax_002 PASS decompose_softmax) | ||||||||
Add(StridedSlice_003 PASS substitute_strided_slice_to_reshape) | ||||||||
Add(Inf_Pad_000 PASS) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please sort in alphabetical order There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Instead of sorting, what about separate
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
👍 |
||||||||
|
||||||||
# CSE test | ||||||||
|
||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# padding with dynamic shape, others same as Pad_000 | ||
operand { | ||
name: "ifm" | ||
type: FLOAT32 | ||
shape { dim: 1 dim: 1 dim: 3 dim: 2 } | ||
shape_signature { dim: 1 dim: -1 dim: 3 dim: 2 } | ||
} | ||
operand { | ||
name: "padding" | ||
type: INT64 | ||
shape { dim: 4 dim: 2 } | ||
filler { | ||
tag: "explicit" | ||
arg: "0" arg: "0" | ||
arg: "1" arg: "1" | ||
arg: "2" arg: "2" | ||
arg: "0" arg: "0" | ||
} | ||
} | ||
operand { | ||
name: "ofm" | ||
type: FLOAT32 | ||
shape { dim: 1 dim: 1 dim: 7 dim: 2 } | ||
shape_signature { dim: 1 dim: -1 dim: 7 dim: 2 } | ||
} | ||
operation { | ||
type: "Pad" | ||
input: "ifm" | ||
input: "padding" | ||
output: "ofm" | ||
} | ||
input: "ifm" | ||
output: "ofm" |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,6 @@ | ||||||||||||||||||||||
# To check if dynamic dimension properly infered | ||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Sorry, I'll fix it. |
||||||||||||||||||||||
|
||||||||||||||||||||||
RULE "VERIFY_FILE_FORMAT" $(verify_file_format) '=' 1 | ||||||||||||||||||||||
|
||||||||||||||||||||||
RULE "PAD_EXIST" $(op_count PAD) '=' 1 | ||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMHO, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
You're right. |
||||||||||||||||||||||
RULE "PAD_SHAPE" $(tensor_shape ofm) '=' 1,-1,7,2 | ||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The 'shape' expression
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. from ##13998 (comment)
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, thanks for the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a must, but most machines do calculations in 32-bit units, so there's probably no need to reduce it to 8-bit in
for loop
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it.