Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dredd] Introduce new dredd rule for tensor shape #14098

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

icodo98
Copy link
Contributor

@icodo98 icodo98 commented Sep 26, 2024

This commit introduces new dredd-test rule for tensor shape.

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]

This commit introduces new dredd-test rule for tensor shape.

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
@icodo98 icodo98 added PR/ready for review It is ready to review. Please review it. SSAFY labels Sep 26, 2024
@icodo98 icodo98 requested review from a team September 26, 2024 07:48
@kyeong8139
Copy link
Contributor

kyeong8139 commented Sep 26, 2024

Title's Typo check plz. Introdue -> Introduce

@icodo98 icodo98 changed the title [dredd] Introdue new dredd rule for tensor shape [dredd] Introduce new dredd rule for tensor shape Sep 26, 2024
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@shs-park
Copy link
Contributor

shs-park commented Sep 26, 2024

@icodo98,
Could you please add links to the relevant issue and draft PR if they exist?

@icodo98
Copy link
Contributor Author

icodo98 commented Sep 26, 2024

Could you please add links to the relevant issue and draft PR if they exist?

Oops, I forgot it.

related : #13998
draft : #14050

@seanshpark seanshpark merged commit bb52b8b into Samsung:master Sep 26, 2024
8 checks passed
@icodo98 icodo98 deleted the dredd_rule_lib branch September 27, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it. SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants