-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[res] Add TFLiteRecipe for FullyConnected dynamic shape #14157
[res] Add TFLiteRecipe for FullyConnected dynamic shape #14157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment, PTAL.
Anyway the code LGTM
=)
type: "FullyConnected" | ||
fullyconnected_options { | ||
activation: NONE | ||
keep_num_dims: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not strictly necessary, but
It might also be a good to add another recipe that corresponds to the case where keep_num_dims: true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the case with keep_num_dims : true
.
This commit adds TFLiteRecipes for FullyConnected dynamic shape. ONE-DCO-1.0-Signed-off-by: HanJin Choi [email protected]
86f7fb7
to
94ce0c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
LGTM
=)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds TFLiteRecipe for FullyConnected dynamic shape.
ONE-DCO-1.0-Signed-off-by: HanJin Choi [email protected]