Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[res] Add TFLiteRecipe for FullyConnected dynamic shape #14157

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Hanjin-Choi
Copy link
Contributor

This commit adds TFLiteRecipe for FullyConnected dynamic shape.

ONE-DCO-1.0-Signed-off-by: HanJin Choi [email protected]

@Hanjin-Choi Hanjin-Choi requested review from seanshpark and a team October 4, 2024 01:27
zetwhite
zetwhite previously approved these changes Oct 4, 2024
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shs-park shs-park requested a review from a team October 4, 2024 07:10
shs-park
shs-park previously approved these changes Oct 4, 2024
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment, PTAL.
Anyway the code LGTM
=)

type: "FullyConnected"
fullyconnected_options {
activation: NONE
keep_num_dims: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not strictly necessary, but
It might also be a good to add another recipe that corresponds to the case where keep_num_dims: true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the case with keep_num_dims : true.

This commit adds TFLiteRecipes for FullyConnected dynamic shape.

ONE-DCO-1.0-Signed-off-by: HanJin Choi [email protected]
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM
=)

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 49d45bf into Samsung:master Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants