[NUI] Add WidgetComponent for ComponentBasedApplication #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscholb
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
Internal API ChangedAdded: 10, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.NUIWidgetComponent
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Window Tizen.NUI.NUIWidgetComponent::Window()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.NUIWidgetComponent::OnCreate(System.Int32,System.Int32)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::.ctor()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnDestroy(System.Boolean)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnPause()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnResume()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnStart(System.Boolean)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnStop()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Applications.ComponentBased.Common.IWindowProxy Tizen.NUI.NUIWidgetComponent::CreateWindowInfo(System.Int32,System.Int32)
|
Seoyeon2Kim
reviewed
Oct 10, 2024
| @@ -0,0 +1,94 @@ | |||
| /* | |||
| * Copyright(c) 2021 Samsung Electronics Co., Ltd. | |||
There was a problem hiding this comment.
Very minor
Suggested change
| * Copyright(c) 2021 Samsung Electronics Co., Ltd. | |
| * Copyright(c) 2024 Samsung Electronics Co., Ltd. |
| } | ||
|
|
||
| /// <summary> | ||
| /// Overrides this method if want to handle behavior when the component receives the appcontrol message. |
There was a problem hiding this comment.
Suggested change
| /// Overrides this method if want to handle behavior when the component receives the appcontrol message. | |
| /// Overrides this method if you want to handle behavior when the component receives the appcontrol message. |
| @@ -0,0 +1,101 @@ | |||
| /* | |||
| * Copyright (c) 2022 Samsung Electronics Co., Ltd. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 Samsung Electronics Co., Ltd. | |
| * Copyright (c) 2024 Samsung Electronics Co., Ltd. |
There was a problem hiding this comment.
Thank you for your review. I'll fix it quickly 😊
Adds implementations and samples for WidgetComponent use For more information, please refer to the links below - Tizen.Applications.ComponentBased: https://github.com/Samsung/TizenFX/tree/master/src/Tizen.Applications.ComponentBased - Tizen.Applications.ComponentBased.Default: https://github.com/Samsung/TizenFX/tree/master/src/Tizen.Applications.ComponentBased.Default/Tizen.Applications.ComponentBased.Default - EFL Sample app: https://github.sec.samsung.net/appfw/csharp-component-based-app
Internal API ChangedAdded: 10, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.NUIWidgetComponent
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Window Tizen.NUI.NUIWidgetComponent::Window()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.NUIWidgetComponent::OnCreate(System.Int32,System.Int32)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::.ctor()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnDestroy(System.Boolean)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnPause()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnResume()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnStart(System.Boolean)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIWidgetComponent::OnStop()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Applications.ComponentBased.Common.IWindowProxy Tizen.NUI.NUIWidgetComponent::CreateWindowInfo(System.Int32,System.Int32)
|
|
리뷰 남겨주신 모든분들 감사합니다! 반영하겠습니다 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementations and samples for WidgetComponent use
For more information, please refer to the links below
Description of Change
API Changes