-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Geometry Touch / Gesture Event #6452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.GestureDetector::HandleEvent(Tizen.NUI.BaseComponents.View,Tizen.NUI.Touch)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.GestureDetector::CancelAllOtherGestureDetectors()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.NUIApplication::IsGeometryHittestEnabled()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Void Tizen.NUI.NUIApplication::SetGeometryHittestEnabled(System.Boolean)
|
JoogabYun
force-pushed
the
NewGesture_1112
branch
from
November 12, 2024 02:40
c92d8e7
to
b1b59ee
Compare
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.GestureDetector::HandleEvent(Tizen.NUI.BaseComponents.View,Tizen.NUI.Touch)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.GestureDetector::CancelAllOtherGestureDetectors()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.NUIApplication::IsGeometryHittestEnabled()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Void Tizen.NUI.NUIApplication::SetGeometryHittestEnabled(System.Boolean)
|
JoogabYun
changed the title
Geometry Touch / Gesture Event
[NUI] Geometry Touch / Gesture Event
Nov 12, 2024
JoogabYun
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
November 12, 2024 05:01
JoogabYun
force-pushed
the
NewGesture_1112
branch
from
November 12, 2024 05:03
b1b59ee
to
8d17720
Compare
hinohie
reviewed
Nov 12, 2024
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.GestureDetector::HandleEvent(Tizen.NUI.BaseComponents.View,Tizen.NUI.Touch)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.GestureDetector::CancelAllOtherGestureDetectors()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.NUIApplication::IsGeometryHittestEnabled()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Void Tizen.NUI.NUIApplication::SetGeometryHittestEnabled(System.Boolean)
|
hinohie
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some review points. But basically, new API only be added.. So Approved
JoogabYun
force-pushed
the
NewGesture_1112
branch
from
November 12, 2024 05:13
8d17720
to
d24beab
Compare
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.GestureDetector::HandleEvent(Tizen.NUI.BaseComponents.View,Tizen.NUI.Touch)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.GestureDetector::CancelAllOtherGestureDetectors()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.NUIApplication::IsGeometryHittestEnabled()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Void Tizen.NUI.NUIApplication::SetGeometryHittestEnabled(System.Boolean)
|
jaehyun0cho
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
새로운 geometry touch/gesture event 전파 방식입니다.
SetGeometryHittestEnabled(true)를 하게 되면 새로운 이벤트 전파방식으로 동작합니다.
touch 이벤트는 geometry 기준으로 전파가 되며 gesture는 해당 터치 이벤트를 받아 인식하게 됩니다.
그래서 터치이벤트를 받아 consume하게 되면 더이상 터치 이벤트가 전달되지 않아 하위의 뷰에서 제스처도 인식할 수 없습니다.
참고 페이지
https://confluence.sec.samsung.net/display/GFX/%5B2024+tizen%5D+New+Touch+and+Gesture
hittest를 통해 hit되는 actor를 찾는 과정
기존 방식
신규 방식
Touch 이벤트가 전파되는 과정
기존 방식
신규 방식
Hover 이벤트가 전파되는 과정
기존 방식
신규 방식
Gesture 인식
API Changes