Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Ensure UnmanagedType.U1 mark add for bool return type #6453

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[NUI] Ensure UnmanagedType.U1 mark add for bool return type #6453

merged 1 commit into from
Nov 12, 2024

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Nov 12, 2024

Ensure some native binded API which bool return add MarshalAs(UnmanagedType.U1 ) keyword.

jaehyun0cho
jaehyun0cho approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seoyeon2Kim
Seoyeon2Kim approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Seoyeon2Kim Seoyeon2Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooooood~

@hinohie hinohie merged commit c3f478e into Samsung:DevelNUI Nov 12, 2024
3 checks passed
@hinohie hinohie deleted the ensure_unmanaged branch November 12, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seoyeon2Kim Seoyeon2Kim Seoyeon2Kim approved these changes

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

Assignees
No one assigned
Labels
Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hinohie @jaehyun0cho @Seoyeon2Kim