Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Block native callback if view is disposed or disposing #6456

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[NUI] Block native callback if view is disposed or disposing #6456

merged 1 commit into from
Nov 19, 2024

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Nov 19, 2024

For now, let we just check for View, ImageView, TextLabel, TextField, TextEditor

jaehyun0cho
jaehyun0cho approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seoyeon2Kim
Seoyeon2Kim approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Seoyeon2Kim Seoyeon2Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..!!!

@hinohie hinohie merged commit 6b154fd into Samsung:DevelNUI Nov 19, 2024
3 checks passed
@hinohie hinohie deleted the guard_native_callback_1 branch November 19, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seoyeon2Kim Seoyeon2Kim Seoyeon2Kim approved these changes

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@wonrst wonrst Awaiting requested review from wonrst wonrst is a code owner

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

Assignees
No one assigned
Labels
Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hinohie @jaehyun0cho @Seoyeon2Kim