Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Add APIs for setting IME position, cursor theme name. #6463

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[NUI] Add APIs for setting IME position, cursor theme name. #6463

merged 1 commit into from
Nov 26, 2024
+138 −0

Conversation

huayongxu
Copy link
Contributor

Description of Change

csharp-binder patch:
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/320722/

API Changes

  • ACR:

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 17, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::SetCursorThemeName(System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::SetImePositionAndAlignment(Tizen.NUI.Vector2,Tizen.NUI.BaseComponents.WebView/ImeAlignment)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.WebView/ImeAlignment

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::BottomCenter

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::BottomLeft

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::BottomRight

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::MiddleCenter

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::MiddleLeft

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::MiddleRight

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::TopCenter

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::TopLeft

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::TopRight

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings::ImeStyle()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebSettings/WebImeStyle

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings/WebImeStyle::Dynamic

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings/WebImeStyle::Floating

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings/WebImeStyle::Full

hinohie
hinohie reviewed Nov 26, 2024
View reviewed changes
src/Tizen.NUI/src/internal/Interop/Interop.WebSettings.cs Outdated
public static extern void SetImeStyle(global::System.Runtime.InteropServices.HandleRef jarg1, int jarg2);

[global::System.Runtime.InteropServices.DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_WebSettings_GetImeStyle")]
[return: global::System.Runtime.InteropServices.MarshalAs(global::System.Runtime.InteropServices.UnmanagedType.U1)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[return: global::System.Runtime.InteropServices.MarshalAs(global::System.Runtime.InteropServices.UnmanagedType.U1)]

We don't need to add this MarshalAs keyword for integer return type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Thanks.

@huayongxu huayongxu closed this Nov 26, 2024
@huayongxu huayongxu reopened this Nov 26, 2024
@huayongxu huayongxu changed the title Add APIs for setting IME position, cursor theme name. [NUI] Add APIs for setting IME position, cursor theme name. Nov 26, 2024
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 17, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::SetCursorThemeName(System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::SetImePositionAndAlignment(Tizen.NUI.Vector2,Tizen.NUI.BaseComponents.WebView/ImeAlignment)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.WebView/ImeAlignment

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::BottomCenter

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::BottomLeft

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::BottomRight

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::MiddleCenter

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::MiddleLeft

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::MiddleRight

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::TopCenter

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::TopLeft

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.WebView/ImeAlignment Tizen.NUI.BaseComponents.WebView/ImeAlignment::TopRight

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings::ImeStyle()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebSettings/WebImeStyle

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings/WebImeStyle::Dynamic

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings/WebImeStyle::Floating

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebSettings/WebImeStyle Tizen.NUI.WebSettings/WebImeStyle::Full

dongsug-song
dongsug-song approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@dongsug-song dongsug-song merged commit 298025a into Samsung:API12 Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsug-song dongsug-song dongsug-song approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

@hinohie hinohie Awaiting requested review from hinohie hinohie is a code owner

Assignees
No one assigned
Labels
Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huayongxu @TizenAPI-Bot @hinohie @dongsug-song