Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration_support): raise explicit error on conditional steps addition #819

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

miltolstoy
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Unit Test Results

709 tests   706 ✔️  26m 14s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit 2a0b287.

♻️ This comment has been updated with latest results.

# TODO: implement support of conditional steps addition and multiplication
# https://github.com/Samsung/Universum/issues/709
def test_conditional_step_addition(test_env: ConditionalStepsTestEnv, capsys: pytest.CaptureFixture) -> None:
config_lines: List[str] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to store config as a list of lines instead of multiline text variable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made similar to the _write_config_file() for uniformity.

@github-actions
Copy link

Here is the summarized build result:
5. Executing build steps
5.1. [ 1/8 ] Create virtual environment - Success
5.2. [ 2/8 ] Update Docker images - Success
5.3. [ 3/8 ] Install Universum for tests - Success
5.4. [ 4/8 ] Make - Success
5.5. Collecting artifacts for the 'Make' step - Success
5.6. [ 5/8 ] Make tests - Success
5.7. Collecting artifacts for the 'Make tests' step - Success
5.8. [ 6/8 ] Collect test results - Success
5.9. Collecting artifacts for the 'Collect test results' step - Success
5.10. [ 7/8 ] Run static pylint - Failed
5.11. [ 8/8 ] Run static type checker - Success

Here is the link to Github Actions build: https://github.com/Samsung/Universum/actions/runs/5946802787

@miltolstoy miltolstoy merged commit 63ef9e9 into conditional_steps Aug 25, 2023
10 of 11 checks passed
@miltolstoy miltolstoy deleted the cs_addition branch August 25, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants