[WIP] Convert to V2 addon #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderKnauff
force-pushed
the
v2-addon
branch
2 times, most recently
from
0ccf1b2 to
19e2e45
Compare
SanderKnauff
changed the title
SanderKnauff
force-pushed
the
v2-addon
branch
4 times, most recently
from
7c926a6 to
31ce1af
Compare
This covers part 1 of the Embroider v2 addon conversion guide See: https://github.com/embroider-build/embroider/blob/main/docs/porting-addons-to-v2.md
This commit covers part 2 of the Embroider V2 addon conversion guide See: https://github.com/embroider-build/embroider/blob/main/docs/porting-addons-to-v2.md
The import of CSS has temporarily been removed since the next step will change the addon directory into a proper v2 addon. A migration path (or solution) will be provided after the V2 scaffhold is in place. This commit covers part 3 of the Embroider V2 addon conversion guide See: https://github.com/embroider-build/embroider/blob/main/docs/porting-addons-to-v2.md
Macros and tests still seem to be broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR for CI