-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Changed shmem_team_destroy to return void #1168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avincigu in line src/teams_c.c4:147 the code is attempting to return an int even though the function does not return a value. Please remove this return.
teams_c.c: In function ‘shmem_team_destroy’:
teams_c.c:147:12: warning: ISO C forbids ‘return’ with expression, in function returning void [-Wpedantic]
147 | return shmem_internal_team_destroy((shmem_internal_team_t *)team);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
teams_c.c:139:1: note: declared here
139 | shmem_team_destroy(shmem_team_t team)
| ^~~~~~~~~~~~~~~~~~
Looks good - let's just loop in @abrooks98 to see if Intel SHMEM could be affected? (Maybe you checked already?) At a glance, it actually looks like it's already good to go, but I could be wrong. |
Made the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avincigu looks good. Please merge (select squash and merge)
No description provided.