Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Changed shmem_team_destroy to return void #1168

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

avincigu
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@markbrown314 markbrown314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avincigu in line src/teams_c.c4:147 the code is attempting to return an int even though the function does not return a value. Please remove this return.

teams_c.c: In function ‘shmem_team_destroy’:
teams_c.c:147:12: warning: ISO C forbids ‘return’ with expression, in function returning void [-Wpedantic]
147 |     return shmem_internal_team_destroy((shmem_internal_team_t *)team);
|            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
teams_c.c:139:1: note: declared here
139 | shmem_team_destroy(shmem_team_t team)
| ^~~~~~~~~~~~~~~~~~

@davidozog
Copy link
Member

Looks good - let's just loop in @abrooks98 to see if Intel SHMEM could be affected? (Maybe you checked already?) At a glance, it actually looks like it's already good to go, but I could be wrong.

@davidozog davidozog requested a review from abrooks98 February 13, 2025 13:07
@avincigu
Copy link
Collaborator Author

@avincigu in line src/teams_c.c4:147 the code is attempting to return an int even though the function does not return a value. Please remove this return.

teams_c.c: In function ‘shmem_team_destroy’:
teams_c.c:147:12: warning: ISO C forbids ‘return’ with expression, in function returning void [-Wpedantic]
147 |     return shmem_internal_team_destroy((shmem_internal_team_t *)team);
|            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
teams_c.c:139:1: note: declared here
139 | shmem_team_destroy(shmem_team_t team)
| ^~~~~~~~~~~~~~~~~~

Made the change

Copy link
Collaborator

@abrooks98 abrooks98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@markbrown314 markbrown314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avincigu looks good. Please merge (select squash and merge)

@avincigu avincigu merged commit 290f955 into Sandia-OpenSHMEM:main Feb 13, 2025
36 checks passed
@avincigu avincigu deleted the destroyvoid branch February 13, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants