-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.15 RFE] Adding views and entities for sca alerts on 6.15 #1026
base: master
Are you sure you want to change the base?
[6.15 RFE] Adding views and entities for sca alerts on 6.15 #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just remove that comment and ACK
8923fc0
to
f6f2277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK codewise, @ColeHiggins2 Could you rebase and run the PRT here?
def sca_alert(self): | ||
view = self.navigate_to(self, 'All') | ||
wait_for( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColeHiggins2 Ping. are you done with changes on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM.
Given the age of this PR, I would rebase and also add labels CherryPick
& 6.15.z
.
These additions are for getting the sca-alerts for the latest 6.15 Feature.
Jira: SAT-20200
Robottelo: SatelliteQE/robottelo#13004