Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Pagination refactor #1031

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #947

This PR aims to refactor Pagination in Airgun.

First step with this commit is to change Pagination in individual views to Widgetastic's implementation. It's methods should be compatible with Airgun's existing Pagination widget, so no need to change code that uses it.

Next step is to look into SatTable and it's Pagination.

* update views to use Widgetastic's PF4 Pagination

* rename to PF4Pagination

* fix SatTable locator

* add Pagination to location for testing

* pre-commit

(cherry picked from commit cd24e60)
@Satellite-QE Satellite-QE added 6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 9, 2023
@Satellite-QE
Copy link
Contributor Author

trigger: test-robottelo

@mstrlc
Copy link
Contributor

mstrlc commented Nov 14, 2023

PRT passes on parent PR.

@omkarkhatavkar omkarkhatavkar merged commit 918e233 into 6.14.z Nov 16, 2023
11 of 12 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.14.z-cd24e60147bca6183c561e513bdebfc1509d4494 branch November 16, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants