Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] host_new>content>errata tab pagination #1202

Merged

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1152

Purpose

  • supports robottelo #13767
  • Add new host UI support for reading errata tab pagination.
  • method could be extended to any content>{tab with pagination} in New Host UI page once working.

Solution

-Added new method clear() to SearchInput class (aigun/widgets.py)
-usage in the airgun view like soview.content.errata.searchbar.clear()
-Now using this in apply_erratas() method (entities/host_new.py), to clear the searchbar of any possible value present, when no search passed to apply_erratas(), meaning show and apply all errata with a blank searchbar.
-We also clear the searchbar in apply_erratas() after installing, that way any search value passed does not persist in the searchbar.

Issue, Resolved

  • When reading info from PF4Pagination object in views/host_new.py@362, we get an empty dictionary with no information. Solved
  • When the method apply_erratas(entity, search) is run, it will leave the searchbar filled, and keep it filled until the view is reset.
  • Workaround: Before accessing view.content.errata.pagination, we pass ' ' to searchbar, to display all available errata unfiltered. In case the searchbar was left occupied by a method run previously. I have been looking for a better way or built in method to clear the searchbar /unfilter, before geting pagination.

Click button to clear searchbar

docstring fix

(cherry picked from commit 5b0ca76)
@Satellite-QE Satellite-QE added 6.15.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 26, 2024
@vsedmik vsedmik added the AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing label Jan 26, 2024
@vsedmik
Copy link
Contributor

vsedmik commented Jan 26, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k end_to_end

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CP looks correct, PRT passed

@sambible sambible merged commit 660b9c7 into 6.15.z Jan 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants