-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CV UI - Promote, Publish, Add Content #939
Conversation
view = self.navigate_to(self, 'Edit', entity_name=entity_name) | ||
# need a wait to recognize the loading is complete | ||
# sleep works for now | ||
time.sleep(3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no hard sleep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the old me omkar, I can fix it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
returning to this: have tried various other things, and the sleep is the only thing consistently working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say keep it then if there is no other way.
As I believe in many cases there is unfortunately none. :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then I would remove # sleep works for now
comment :)
This is going to stay in draft for a while, and Publish will get merged. I want to hold my Promote work here, but I jumped the gun on working on it, so I'll come back in a few sprints and revisit this one. :) |
@sambible any updates on this? |
@sambible bump |
@sambible Any update on this one? |
@shweta83 active development again, should have an update on this soon. Hopefully I can get it ready somewhat quickly, and we can get your e2e tests unblocked. |
Hoping to get some eyes on this soon, fixing this PR up and adding more support for things. Might be a bear to review, especially considering the age of some of the code in here ( Lai Tran wrote some portions of this ) Looking to demonstrate this working with a few end - to end test cases coming very soon. |
Can you please provide some more details in the description about the PR. It would be helpful to review the PR. |
3a8eefa
to
dec1ed5
Compare
739cc7f
to
91bee73
Compare
d9b5aa0
to
291fcc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, quick comment about read_cv
method from local use and PRT
Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>
be467c5
to
2fedb62
Compare
* Edit/Versions/Publish/Promote work * Large changes to make publish/promote/composite/add content work * Small adjustments to docstrings * Add wait_displayed to repo table read * Testing a hard sleep * Try different ways to wait on the table to load properly * Add wait_displayed to read_cv method Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com> * Add wait_for statements in various places to increase consistency * Remove comment about sleep --------- Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com> (cherry picked from commit 98c53e4)
* Edit/Versions/Publish/Promote work * Large changes to make publish/promote/composite/add content work * Small adjustments to docstrings * Add wait_displayed to repo table read * Testing a hard sleep * Try different ways to wait on the table to load properly * Add wait_displayed to read_cv method Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com> * Add wait_for statements in various places to increase consistency * Remove comment about sleep --------- Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com> (cherry picked from commit 98c53e4) Co-authored-by: Samuel Bible <sbible@redhat.com>
This PR is adding support for Publishing CVs, Promoting CVs, Adding Content to CVs, among other changes that are required to bring this work up to current formatting standards, as well as function properly.
Testing of various methods added here in this PR: SatelliteQE/robottelo#16238