Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV UI - Promote, Publish, Add Content #939

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Aug 23, 2023

This PR is adding support for Publishing CVs, Promoting CVs, Adding Content to CVs, among other changes that are required to bring this work up to current formatting standards, as well as function properly.

Testing of various methods added here in this PR: SatelliteQE/robottelo#16238

@sambible sambible self-assigned this Aug 23, 2023
@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z labels Aug 23, 2023
@sambible sambible changed the title Edit/Versions/Publish/Promote work CV Promote Aug 30, 2023
view = self.navigate_to(self, 'Edit', entity_name=entity_name)
# need a wait to recognize the loading is complete
# sleep works for now
time.sleep(3)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no hard sleep!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the old me omkar, I can fix it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returning to this: have tried various other things, and the sleep is the only thing consistently working

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say keep it then if there is no other way.
As I believe in many cases there is unfortunately none. :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then I would remove # sleep works for now comment :)

@omkarkhatavkar
Copy link

@sambible if this PR is going to be included in the Publish PR #948 , please close this one

@sambible
Copy link
Contributor Author

sambible commented Sep 6, 2023

This is going to stay in draft for a while, and Publish will get merged. I want to hold my Promote work here, but I jumped the gun on working on it, so I'll come back in a few sprints and revisit this one. :)

@Gauravtalreja1
Copy link
Collaborator

@sambible any updates on this?

@Gauravtalreja1
Copy link
Collaborator

@sambible bump

@shweta83
Copy link
Contributor

@sambible Any update on this one?

@sambible
Copy link
Contributor Author

@shweta83 active development again, should have an update on this soon. Hopefully I can get it ready somewhat quickly, and we can get your e2e tests unblocked.

@sambible sambible marked this pull request as ready for review September 4, 2024 21:45
@sambible sambible changed the title CV Promote CV UI - Promote, Publish, Add Content Sep 4, 2024
@sambible
Copy link
Contributor Author

sambible commented Sep 4, 2024

Hoping to get some eyes on this soon, fixing this PR up and adding more support for things. Might be a bear to review, especially considering the age of some of the code in here ( Lai Tran wrote some portions of this )

Looking to demonstrate this working with a few end - to end test cases coming very soon.

@shweta83
Copy link
Contributor

shweta83 commented Sep 5, 2024

Can you please provide some more details in the description about the PR. It would be helpful to review the PR.

@sambible sambible added AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.15.z 6.16.z labels Sep 6, 2024
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, quick comment about read_cv method from local use and PRT

airgun/entities/contentview_new.py Show resolved Hide resolved
Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>
damoore044 added a commit to damoore044/airgun that referenced this pull request Oct 17, 2024
@sambible sambible merged commit 98c53e4 into SatelliteQE:master Oct 17, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
* Edit/Versions/Publish/Promote work

* Large changes to make publish/promote/composite/add content work

* Small adjustments to docstrings

* Add wait_displayed to repo table read

* Testing a hard sleep

* Try different ways to wait on the table to load properly

* Add wait_displayed to read_cv method

Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>

* Add wait_for statements in various places to increase consistency

* Remove comment about sleep

---------

Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>
(cherry picked from commit 98c53e4)
vsedmik pushed a commit that referenced this pull request Oct 18, 2024
* Edit/Versions/Publish/Promote work

* Large changes to make publish/promote/composite/add content work

* Small adjustments to docstrings

* Add wait_displayed to repo table read

* Testing a hard sleep

* Try different ways to wait on the table to load properly

* Add wait_displayed to read_cv method

Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>

* Add wait_for statements in various places to increase consistency

* Remove comment about sleep

---------

Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>
(cherry picked from commit 98c53e4)

Co-authored-by: Samuel Bible <sbible@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z 6.14.z 6.15.z 6.16.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants