Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Fix clean button locator in PF4 search. #974

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #965

As it was, we were getting an error when searching for the element, getting False for is_displayed. Consequently, the clear button was not clicked and a generic browser clear was called instead. The text disappeared for a bit and then it got re-filled to the search field.
It caused failures in tests such as
tests/foreman/ui/test_dashboard.py::test_positive_task_status
Changing type and locator fixes the issue.

As it was, we were getting an error when searching for the element,
getting False for is_displayed. Consequently, the clear button was
not clicked and a generic browser clear was called instead.
The text disappeared for a bit and then it got re-filled to the
search field.
It caused failures in tests such as
tests/foreman/ui/test_dashboard.py::test_positive_task_status
Changing type and locator fixes the issue.

(cherry picked from commit 80b7eb9)
@Satellite-QE Satellite-QE added 6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 14, 2023
@Satellite-QE
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_dashboard.py::test_positive_task_status tests/foreman/ui/test_contentview.py::test_positive_end_to_end tests/foreman/ui/test_media.py::test_positive_end_to_end

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing label Sep 14, 2023
@Satellite-QE Satellite-QE self-assigned this Sep 14, 2023
@omkarkhatavkar omkarkhatavkar merged commit 2bf7496 into 6.14.z Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants