Skip to content

Commit

Permalink
Modify content and return value after timeout
Browse files Browse the repository at this point in the history
This PR expicitly sets manifest.content to `None` and returns the
manifest object when a manifest export job times out. This change
facilitates the failover to cloned manifests in Robottelo. Previously,
failed export jobs triggered an exception in Robottelo when manifester
fixtures attempted to upload manifests because, in those cases, the
manifest object did not contain a `content` attribute.
  • Loading branch information
synkd committed Sep 6, 2023
1 parent f5b3433 commit 4747d3e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion manifester/manifester.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,8 @@ def trigger_manifest_export(self):
break
request_count += 1
if limit_exceeded:
return
self.content = None
return self
export_job = export_job.json()
export_href = export_job["body"]["href"]
manifest = simple_retry(
Expand Down

0 comments on commit 4747d3e

Please sign in to comment.