-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 6.15.0 #1002
Version 6.15.0 #1002
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 6 6
Lines 3047 3047
=======================================
Hits 2808 2808
Misses 239 239 ☔ View full report in Codecov by Sentry. |
@lpramuk We have releases auto-created but that is for the master branch only and is being created to understand the changelogs per snap. This looks like a good idea but we had to update the https://github.com/SatelliteQE/nailgun/blob/master/.github/workflows/merge_to_master.yml to update PyPI package for each separate branch version. |
@jyejare I just want
I don't want to release it to pypi - we always install nailgun by branches. Good start is to bump module version after each branching. X.Y.0 In future we could bump the version in z digit too if needed and release to pypi. But then it would be conflicting - tagging master with inappropriate 6.14.z tags - lets restrain releasing to pypi for now |
i'm not opposed to the change in this PR, but I don't think it solves the problem of multiple nailgun versions. it's almost certainly better to replace the currently installed version of nailgun every time with the latest branch using pip git installs directly. |
This pull request has not been updated in the past 45 days. |
This pull request is now being closed after stale warnings. |
We lack proper versioning of nailgun module. For all branches we use currently it says just
0.32.0
Lets get used to updating nailgun package version after each branching/release.
It will be more obvious from what branch we installed the nailgun.
Keeping 6.15.0 in master as nigtly version/future version so being compatible with current tagging.
BTW
For multiple nailguns being installed at the same time we need proper versioning.
pip download
saves nailgun from different branches to the very same filenailgun-0.32.0.zip
. Oops.