[6.12.z] fixed the type error for some remaining entities #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c23c324)
Satellite-QE
added
6.12.z
Auto_Cherry_Picked
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.12.z #1030 +/- ##
=========================================
Coverage ? 93.22%
=========================================
Files ? 6
Lines ? 2924
Branches ? 0
=========================================
Hits ? 2726
Misses ? 198
Partials ? 0 ☔ View full report in Codecov by Sentry. |
pondrejk
approved these changes
Nov 9, 2023
pondrejk
deleted the
cherry-pick-6.12.z-c23c324815fb5a5ca42d4ad4cdfc272b906928b8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #1029
Description of changes
Getting TypeError: Webhooks.init() got multiple values for argument 'server_config' after the move from entities.Webhook to target_sat.api.Webhook.
(SatelliteQE/robottelo#13060 (comment))
SatelliteQE/robottelo#13048
Changes
Removing the call to find the class indirectly and changing to direct call as other entities