Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] fixed the type error for some remaining entities #1031

Merged

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1029

Description of changes

Getting TypeError: Webhooks.init() got multiple values for argument 'server_config' after the move from entities.Webhook to target_sat.api.Webhook.

(SatelliteQE/robottelo#13060 (comment))
SatelliteQE/robottelo#13048

Changes

Removing the call to find the class indirectly and changing to direct call as other entities

@Satellite-QE Satellite-QE added 6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (6.14.z@0e9edb5). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             6.14.z    #1031   +/-   ##
=========================================
  Coverage          ?   92.15%           
=========================================
  Files             ?        6           
  Lines             ?     3047           
  Branches          ?        0           
=========================================
  Hits              ?     2808           
  Misses            ?      239           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pondrejk pondrejk merged commit 9d5768f into 6.14.z Nov 9, 2023
19 checks passed
@pondrejk pondrejk deleted the cherry-pick-6.14.z-c23c324815fb5a5ca42d4ad4cdfc272b906928b8 branch November 9, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants