Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the PRT result and labels on github comment #1089

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

omkarkhatavkar
Copy link

@omkarkhatavkar omkarkhatavkar commented Feb 15, 2024

Details

SatelliteQE/robottelo#13979
SatelliteQE/robottelo#14093

Problem Statement

  1. Currently, the labels PRT-Passed and PRT-Failed are added based on the results of the Pull Request Testing (PRT). However, when contributors update the pull request with new commits, these labels might remain, leading to potential confusion. There is a need to automatically remove these labels when new commits are added to the pull request.
  2. Currently, the PRT result gets clean after a new commit and there is no way for PR to know what happened with the result. PRT passed/failed labels also need to be added automatically this helps in reviewing the PR quickly and merging them

Solution

  1. Add the dispatch workflow that takes care of this thing from the Jenkins CI update the GitHub comment with all details and apply the filter.
  2. To address this issue, we propose implementing a solution using GitHub Actions (GHA). The solution involves periodically checking the GitHub status API to monitor for new commits on the pull request. Upon detecting a new commit, the workflow will automatically remove the PRT-Passed and PRT-Failed labels from the pull request. This ensures that the labels accurately reflect the current status of the pull request, reducing confusion and maintaining clarity for reviewers and contributors.

Test Result

https://github.com/omkarkhatavkar/robottelo/actions/runs/7916581527/job/21610780591?pr=216

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (a74cabf) to head (520748f).
Report is 1 commits behind head on master.

❗ Current head 520748f differs from pull request most recent head 39fc9f7. Consider uploading reports for the commit 39fc9f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
- Coverage   92.02%   92.00%   -0.02%     
==========================================
  Files           6        6              
  Lines        3058     3053       -5     
==========================================
- Hits         2814     2809       -5     
  Misses        244      244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z 6.13.z 6.14.z 6.15.z labels Feb 15, 2024
JacobCallahan
JacobCallahan previously approved these changes Feb 15, 2024
@omkarkhatavkar
Copy link
Author

Dont worry about the failing check here as It will be going to get added. It will work only after getting merge because the github token for SatQE is inside the repo.

@omkarkhatavkar omkarkhatavkar force-pushed the prt_result_labels branch 2 times, most recently from 237bba6 to cd44202 Compare February 26, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z 6.13.z 6.14.z 6.15.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants