-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update entity object with parametrized server_config rather default #1106
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
- Coverage 92.03% 92.00% -0.04%
==========================================
Files 6 6
Lines 3052 3053 +1
==========================================
Hits 2809 2809
- Misses 243 244 +1 ☔ View full report in Codecov by Sentry. |
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried with robottelo + nailgun with this PR fetched:
pytest tests/foreman/api/test_role.py -k test_negative_assign_taxonomies_by_org_admin
============================================= test session starts ==============================================
tests/foreman/api/test_role.py . [100%]
@pondrejk Do you have some more tests to try, just dont wanted to break something working |
trigger: test-robottelo |
1 similar comment
trigger: test-robottelo |
I ran some read queries with custom server config and the returned object contained the supplied credentials. When querying without any server config specified, the object contained default credentials as expected. When supplying invalid content as server config, exception is returned as expected. I'd say it's safe to get this in |
Description of changes
Currently server_config was not getting set while reading the entity API call using target_sat
After this PR the
dom
object or any other api component object can access the API calls using the custom server_config set by parameter .