-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json response to entity creation error message #1119
Add json response to entity creation error message #1119
Conversation
* Makes the error message information more detailed and informative * Possibility to write more precise assertions Signed-off-by: dosas <[email protected]>
0fc2659
to
43b50eb
Compare
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Addition @dosas
PRT Result
|
@omkarkhatavkar I sadly cannot set the labels. Do we need additional reviewers? |
@JacobCallahan @jyejare @ogajduse Looks an interesting PR. We need more review to merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK on the changes. However, @dosas are there any existing tests (in robottelo) that this change would impact?
This should not affect the robottelo tests. The tests I have seen so far only check for |
Description of changes
Add json response to entity creation error message
There are some robottelo tests that would greatly benefit from more precise assertions on error messages, i.e.
tests/foreman/api/test_repository.py::TestRepository::test_negative_update_checksum_with_on_demand_policy (or other tests in this module)
I doubt that the supposed error message should be:
Upstream API documentation, plugin, or feature links
None
Functional demonstration
Example:
before:
after
Additional Information
None