-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new verify_checksum endpoints #1138
Add new verify_checksum endpoints #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you might be missing the product and capsule endpoints in the test_entities test? I might be misreading this, though.
Capsule is added here and Product here to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check doc string?
:param synchronous: What should happen if the server returns an HTTP | ||
202 (accepted) status code? Wait for the task to complete if | ||
``True``. Immediately return the server's response otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my understanding about synchronous execution,
if synchronous=True
then don't wait for current task to execute completely and go for next step
if synchronous=False
then wait till current execution to finish completely.
Please correct me if I am wrong.
:param synchronous: What should happen if the server returns an HTTP | |
202 (accepted) status code? Wait for the task to complete if | |
``True``. Immediately return the server's response otherwise. | |
:param synchronous: What should happen if the server returns an HTTP | |
202 (accepted) status code? Immediately return the server's response | |
if synchronous is ``True``. Wait for the task to complete otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it's exaclty the opposite - synchronous means we wait until the task is finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I see every nailgun entities define doc string in same way.
0231f6d
to
0da546e
Compare
rebased |
Description of changes
Upstream API documentation, plugin, or feature links
stream.satellite.com/apidoc/v2/capsule_content/verify_checksum.en.html
stream.satellite.com/apidoc/v2/content_view_versions/verify_checksum.en.html
any.satellite.com/apidoc/v2/products_bulk_actions/verify_checksum_products.en.html
any.satellite.com/apidoc/v2/repositories/verify_checksum.en.html
Functional demonstration
Additional Information
The new endpoints are not present in snap 54 yet, packit is needed for testing.