Add repo_data option to host registration command #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@dosas When would you like to get this PR merged? Before the upstream PR is merged or after? IIRC, we nailgun can not define fields that are not implemented in API unless an |
The above mentioned PR is already merged since a few months. The field should be part of the latest foreman? |
Gauravtalreja1
added
CherryPick
dosas
force-pushed
the
repo-data-host-registration
branch
from
c7965a4 to
02289d0
Compare
amolpati30
approved these changes
Nov 26, 2024
|
@dosas Can you please rebase the branch? |
dosas
force-pushed
the
repo-data-host-registration
branch
from
02289d0 to
eafa44c
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit ca5283d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add repo_data option to host registration command
Upstream API documentation, plugin, or feature links
The foreman upstream api is not up to date so I can only link the PR
theforeman/foreman#10162
Functional demonstration
I am executing it via robottelo I do not know how to extract the raw api call.
Additional Information
None