Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.32.0 #620

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Release 0.32.0 #620

merged 1 commit into from
Mar 20, 2019

Conversation

sean797
Copy link
Contributor

@sean797 sean797 commented Mar 1, 2019

Is everyone is happy to do a release? Doing this in place of theforeman/foreman-ansible-modules#245

Whoever merges this needs to create and push a tag, then create a release in GitHub. I'm happy to do it if no else wants to.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.866% when pulling aa6725a on sean797:release into ff75d79 on SatelliteQE:master.

@ogajduse
Copy link
Member

ogajduse commented Mar 1, 2019

I am open to this. But I will leave the decision up to the others.

@ogajduse
Copy link
Member

ogajduse commented Mar 8, 2019

What do you think about the release @san7ket? Asking you as a maintainer, I'm not sure which other reviewers I should mention here.

@jhutar
Copy link
Member

jhutar commented Mar 8, 2019

Also tagging other tier2 reviewers here: @abalakh @ldjebran @jyejare @oshtaier as this is important for other team.

@san7ket
Copy link
Contributor

san7ket commented Mar 11, 2019

I am good for release, but I would really like we focus on [1] after this release and make this last release form Master branch

#581

@jhutar
Copy link
Member

jhutar commented Mar 14, 2019

Hello @abalakh @ldjebran @jyejare @oshtaier. Still one more reviewer is needed.

omkarkhatavkar
omkarkhatavkar approved these changes Mar 19, 2019
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@JacobCallahan
Copy link
Member

ACK

@JacobCallahan JacobCallahan merged commit 999c8a4 into SatelliteQE:master Mar 20, 2019
@sean797 sean797 deleted the release branch March 20, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@san7ket san7ket san7ket approved these changes

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sean797 @coveralls @ogajduse @jhutar @san7ket @JacobCallahan @omkarkhatavkar