Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce docstring standards for Ruff #994

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

JacobCallahan
Copy link
Member

Most rules are used, but a few are ignored for style.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (08c4bb8) 92.15% compared to head (465b6ef) 92.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files           6        6           
  Lines        3047     3047           
=======================================
  Hits         2808     2808           
  Misses        239      239           
Files Changed Coverage Δ
nailgun/client.py 87.64% <ø> (ø)
nailgun/config.py 97.59% <ø> (ø)
nailgun/entities.py 91.30% <ø> (ø)
nailgun/entity_fields.py 100.00% <ø> (ø)
nailgun/entity_mixins.py 95.86% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobCallahan JacobCallahan force-pushed the master branch 2 times, most recently from ea49d4e to de16e79 Compare September 13, 2023 20:10
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments left.

nailgun/entities.py Outdated Show resolved Hide resolved
tests/test_entities.py Outdated Show resolved Hide resolved
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jake!

Most rules are used, but a few are ignored for style.
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love ruff already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z 6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants